Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble/1792/non blocking artifact production in aggregator #1828

Merged
merged 10 commits into from
Jul 16, 2024
Merged

Ensemble/1792/non blocking artifact production in aggregator #1828

merged 10 commits into from
Jul 16, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Jul 15, 2024 •
edited
Loading

Content

This PR isolate artifact production in a separate thread to avoid blocking the signature of new open messages when the aggregator is computing the artifact for a signed entity type.

The signed entity type is locked during the operation to prevent to compute two signed entity of the same type at the same time.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1792

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 52s ⏱️ +5s
1 153 tests +5  1 153 ✅ +5  0 💤 ±0  0 ❌ ±0 
1 319 runs  +5  1 319 ✅ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 1019bbf. ± Comparison against base commit 556b687.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel marked this pull request as ready for review July 15, 2024 15:52
@sfauvel sfauvel force-pushed the ensemble/1792/non-blocking-artifact-production-in-aggregator branch from 06d42cc to 70fa6e4 Compare July 15, 2024 15:54
@sfauvel sfauvel temporarily deployed to testing-preview July 15, 2024 16:02 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 15, 2024 16:02 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the ensemble/1792/non-blocking-artifact-production-in-aggregator branch from 70fa6e4 to b30b52c Compare July 15, 2024 16:04
@sfauvel sfauvel temporarily deployed to testing-preview July 15, 2024 16:12 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 15, 2024 16:12 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-aggregator/src/services/signed_entity.rs Outdated Show resolved Hide resolved
Alenar
Alenar approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mithril-aggregator/tests/test_extensions/runtime_tester.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/services/signed_entity.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 16, 2024
View reviewed changes
mithril-aggregator/src/services/signed_entity.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/services/signed_entity.rs Outdated Show resolved Hide resolved
dlachaume and others added 10 commits July 16, 2024 14:23
@dlachaume @sfauvel
Add test for SignedEntityService that create artifact for multiple …
ac55f5f 
…signed entity types

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@dlachaume @sfauvel
Add create_artifact_return_join_handle that call create_artifact …
b559ad7 
…in a separate task

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@dlachaume @sfauvel
Refactor Signed entity service unit tests
534a2dd 
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@dlachaume @sfauvel
Implement lock/unlock mechanism for signed entity types during the cr…
63b1269 
…eate artifact process
@dlachaume @sfauvel @Alenar
Wire new create_artifact implementation
f0b53d9 
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Co-authored-by: DJO <Alenar@users.noreply.github.com>
@sfauvel
Add a busy waiting of signed entity type for integration tests
e5ed39a
@sfauvel
Remove useless code
8cc6bb8
@sfauvel
Update changelog
a73fcde
@sfauvel
Replace unwrap by a with_context on thread creating artifact
c4df02d
@sfauvel
Upgrade aggregator version from 0.5.42 to 0.5.43
1019bbf
@sfauvel sfauvel force-pushed the ensemble/1792/non-blocking-artifact-production-in-aggregator branch from e2bc74e to 1019bbf Compare July 16, 2024 12:29
@sfauvel sfauvel temporarily deployed to testing-preview July 16, 2024 12:36 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 16, 2024 12:36 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 2d04e58 into main Jul 16, 2024
40 checks passed
@sfauvel sfauvel deleted the ensemble/1792/non-blocking-artifact-production-in-aggregator branch July 16, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non blocking artifact production in aggregator
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume